test(e2e): extend Germany onboarding flow through Pre-Onboarding Requirements - #1370

watchForBenefitsSchema silently fell back to an empty schema on a
non-2xx response, turning a real API failure into a confusing
downstream submit/validation failure instead of a clear error at the
point of interception.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

- Register the benefit-offers schema listener before Introduction
  submits (creates the employment), not before Contract Details:
  useBenefitOffersSchema is enabled as soon as employmentId exists,
  so the request had already resolved by the time the old listener
  was registered, and waitForResponse hung until timeout.
- Feed createHeadlessForm a real nested initialValues object instead
  of a flat one keyed by the dotted data-field string. The dotted
  string is only valid as a DOM lookup key; the schema's own if/then
  conditionals read a nested object, so a benefit's "value" field
  never appeared once its "filter" was picked.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Replaces fillOnboardingStep4SpainForm's hardcoded sandbox-company
benefit-group UUIDs with the same schema-driven helper the Germany
spec now uses, so both onboarding e2e tests fill Benefits generically
instead of one of them being tied to one company's fixed field names.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…eHeadlessForm

createHeadlessForm is called once and handleValidation is used to
re-evaluate conditionals each round: both jsf v0 and v1 mutate the
same `fields` array in place rather than returning a new one, so
recomputing the whole form from scratch every round was redundant.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Documents the pattern discovered while building the dynamic Benefits
e2e helper: call createHeadlessForm once and recompute conditionals
via handleValidation (which mutates the same fields array in place
for both jsf v0 and v1) instead of re-calling createHeadlessForm on
every value change. Notes the existing src/flows/*/api.ts hooks that
do the latter as accepted legacy debt, not the pattern for new code.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…irements

Fills the gap after Benefits: acknowledges the Time Tracking Policy
checkbox, reviews and signs the ILA, then verifies the review step's
edit buttons become disabled (employment data frozen) and the invite
button is no longer blocked, now that every requirement is finished.

Also fixes the prior assertion that the Review step followed Benefits
directly — the flow actually surfaces a Preview Employment Agreement
step first, which the test now submits.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

CI's sandbox company goes straight from Benefits to Review — the
Preview Employment Agreement step isn't universal, it depends on the
company's account configuration, not the country. My local run's
sandbox account happened to have it enabled; CI's doesn't.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

CI's sandbox company doesn't have this step enabled, so asserting
'Review' directly after Benefits matches today's reality. If the
account config changes and the step gets enabled, this test should
break — that's the signal to update it, not something to paper over
preemptively.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>